Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BGR;15, BGR;16 and BGR;24 access, unpacking and putdata #7303

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Jul 25, 2023

#7209 and #7260 need to exclude BGR;15, BGR;16 and BGR;24 from their tests because these modes cannot be unpacked and used with putdata.

This fixes that. It doesn't add PyAccess support though, since that is deprecated as of #7236

@radarhere radarhere changed the title Added BGR;15, BGR;16 and BGR;24 access and unpacking Support BGR;15, BGR;16 and BGR;24 access, unpacking and putdata Jul 26, 2023
Py_DECREF(seq);
return NULL;
}
/* FIXME: what about scale and offset? */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copying an existing FIXME

/* FIXME: what about scale and offset? */

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worthy of release notes? Maybe too minor, if so, feel free to merge.

@radarhere radarhere merged commit 24d711b into python-pillow:main Oct 6, 2023
55 checks passed
@radarhere radarhere deleted the bgr branch October 6, 2023 10:09
@radarhere radarhere mentioned this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants